[lldb] Add test for @objc @implementation #10889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,4 @@ | |||
| SWIFT_SOURCES = main.swift | |||
| SWIFT_BRIDGING_HEADER = Gadget.h | |||
| SWIFT_PRECOMPILE_BRIDGING_HEADER = NO | |||
There was a problem hiding this comment.
Out of curiosity — why is this needed?
(It basically removes DWARF for the types in the header, so I'm curious if the test depends on the missing debug info)
There was a problem hiding this comment.
yes the test depends on the absence of debug info (to emulate system or third party libraries). Is there a better way to do this?
There was a problem hiding this comment.
For the clangimported part, this is probably them most convenient solution. Maybe we could add a comment like
# This hides the debug info, to make sure ObjC metadata is being used to resolve the types.
adrian-prantl
approved these changes
Jun 26, 2025
|
@swift-ci test |
|
@swift-ci test macOS |
|
I realize I forgot to address the comments, I'll do that in a follow up. |
kastiglione
added a commit
that referenced
this pull request
Jul 2, 2025
* [lldb] Add test for @objc @implementation * Add test decorators * Handle x86_64 bools * Fix test regex (cherry-picked from commit 562f2c1)
kastiglione
added a commit
that referenced
this pull request
Jul 2, 2025
* [lldb] Add test for @objc @implementation * Add test decorators * Handle x86_64 bools * Fix test regex (cherry-picked from commit 562f2c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for SE-0436. Depends on swiftlang/swift#81967