🍒 [lldb] Skip prologue when stepping through swift_task_switch #11181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…untime This will be useful for an upcoming commit. This is also a good candidate to be placed in a non-swift specific file, if there are uses for it upstream. This should be revisited. (cherry picked from commit 283ee15)
Plans stepping through a swift_task_switch are often the last sub-plan for a StepOver action, meaning the plan's destination is also the PC where users will take control of the program. As such, it is crucial that these plans skip over the prologue of their destination function, otherwise most variables won't be in scope. Because x86 and arm diverge on the codegen for `}` in a scope, I had to add a `print` statement in the for loop of the affected test. (cherry picked from commit 3ed5f1d)
|
@swift-ci test |
adrian-prantl
approved these changes
Aug 18, 2025
JDevlieghere
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit just factors out a helper function to be reused by the second commit.
We should find a place for that function in an upstream file later.
Plans stepping through a swift_task_switch are often the last sub-plan
for a StepOver action, meaning the plan's destination is also the PC
where users will take control of the program. As such, it is crucial
that these plans skip over the prologue of their destination function,
otherwise most variables won't be in scope.
rdar://149391650