[LLDB] Set up an explicit Swift module loader #11834
Open
+222
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and populate it with explicitly specified Swift modules. This change allows LLDB to precisely load the explicitly built main module belonging to the current CU from disk. The mere presence of an ESML also recursively enables the same behavior for all of its dependencies, since that functionality is already implemented in the Swift compiler. This fixes a performance cliff encountered when debugging with dSYMs which contain all user modules, but none from the SDK, thus triggering an implicit build of any SDK dependencies. During the transition period this behavior can be disabled with a setting. rdar://164274588
adrian-prantl
requested review from
artemcm,
augusto2112,
cachemeifyoucan and
kastiglione
and removed request for
JDevlieghere
Author
|
@swift-ci test |
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
Mostly looks fine other than I am not sure if CAS module is loaded correctly.
| if (props.GetUseSwiftExplicitModuleLoader()) { | ||
| auto &search_path_opts = GetCompilerInvocation().getSearchPathOptions(); | ||
| std::unique_ptr<swift::ModuleLoader> esml_up = | ||
| swift::ExplicitSwiftModuleLoader::create( |
There was a problem hiding this comment.
Does this loader load module from CAS correctly?
So for caching build, we actually stored the explicit module map inside the CAS so the file is actually loaded from there. We can probably switch that up to use a regular file instead now (I created a special code path because the explicit module map wasn't deterministic before, but it should be now).
Author
|
@swift-ci test windows |
Author
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up an explicit Swift module loader
and populate it with explicitly specified Swift modules.
This change allows LLDB to precisely load the explicitly built main
module belonging to the current CU from disk. The mere presence of an
ESML also recursively enables the same behavior for all of its
dependencies, since that functionality is already implemented in the
Swift compiler.
This fixes a performance cliff encountered when debugging with dSYMs
which contain all user modules, but none from the SDK, thus triggering
an implicit build of any SDK dependencies.
During the transition period this behavior can be disabled with a setting.
rdar://164274588
Depends on:
#11833
swiftlang/swift#85519
swiftlang/swift-driver#2012