Support indexing of mulitple Swift files within the same compiler invocation #2293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
ahoppen
force-pushed
the
multi-file-indexing
branch
from
ed5cf4f to
231214d
Compare
|
@swift-ci Please test |
bnbarham
reviewed
Sep 15, 2025
…files We should not take the number of files in an `UpdateIndexStoreTaskDescription` as an indication on how important the task is. If we do need this functionality, eg. because we want to update the index of files with syntactic matches for a rename term, this should be communicated using a specific purpose similar to `TargetPreparationPurpose`. Since the only reason we update the index store for a file right now is background indexing, such a check is not needed.
ahoppen
force-pushed
the
multi-file-indexing
branch
from
231214d to
d1981de
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Sep 21, 2025
|
Thanks! Exciting to see this in :) |
bnbarham
reviewed
Sep 21, 2025
| if let uri = uris.only { | ||
| header = "Build settings for \(uri.forLogging)" | ||
| } else if let firstUri = uris.first { | ||
| header = "Build settings for \(firstUri.forLogging) and \(firstUri) and \(uris.count - 1) others" |
There was a problem hiding this comment.
Suggested change
| header = "Build settings for \(firstUri.forLogging) and \(firstUri) and \(uris.count - 1) others" | |
| header = "Build settings for \(firstUri.forLogging) and \(uris.count - 1) others" |
There was a problem hiding this comment.
(tests have already passed, another PR is fine)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the indexing performance of most projects is bound by target preparation instead of actual indexing right now, I wasn’t able to measure any performance benefits of this. But it seems like a good thing to add regardless, because it might save CPU cycles.
Fixes #1268