Skip to content

Remove unused internal properties #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025
Merged

Remove unused internal properties #1264

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a67ff90
Remove unused internal properties
d-ronnqvist Jul 30, 2025
1c4a974
Merge branch 'main' into remove-unused-navigator-code
d-ronnqvist Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions Sources/SwiftDocC/Infrastructure/Link Resolution/LinkResolver+NavigatorIndex.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,6 @@ package struct ExternalRenderNode {
externalEntity.topicRenderReference.navigatorTitleVariants
}

/// The variants of the abbreviated declaration of the symbol to display in links.
var fragmentsVariants: VariantCollection<[DeclarationRenderSection.Token]?> {
externalEntity.topicRenderReference.fragmentsVariants
}

/// Author provided images that represent this page.
var images: [TopicImage] {
externalEntity.topicRenderReference.images
Expand All @@ -87,7 +82,6 @@ package struct ExternalRenderNode {
/// A language specific representation of an external render node value for building a navigator index.
struct NavigatorExternalRenderNode: NavigatorIndexableRenderNodeRepresentation {
var identifier: ResolvedTopicReference
var externalIdentifier: RenderReferenceIdentifier
var kind: RenderNode.Kind
var metadata: ExternalRenderNodeMetadataRepresentation

Expand All @@ -109,7 +103,6 @@ struct NavigatorExternalRenderNode: NavigatorIndexableRenderNodeRepresentation {

self.identifier = renderNode.identifier.withSourceLanguages(Set(arrayLiteral: traitLanguage))
self.kind = renderNode.kind
self.externalIdentifier = renderNode.externalIdentifier

self.metadata = ExternalRenderNodeMetadataRepresentation(
title: renderNode.titleVariants.value(for: traits),
Expand Down Expand Up @@ -145,4 +138,4 @@ struct ExternalRenderNodeMetadataRepresentation: NavigatorIndexableRenderMetadat
var fragments: [DeclarationRenderSection.Token]? = nil
var roleHeading: String? = nil
var platforms: [AvailabilityRenderItem]? = nil
}
}