Create new target for common code #1331
Conversation
|
@swift-ci please test |
|
I'm marking this as a draft while I perform a bit more compatibility testing to know if it's fine to move these public types or if we should leave a public typealias to these types instead? |
|
@swift-ci please test |
I found that we needed to add |
|
@swift-ci please test |
d-ronnqvist
force-pushed
the
create-target-for-common-code
branch
from
607d02e to
04d9cc1
Compare
|
@swift-ci please test |
|
@swift-ci please test |
| */ | ||
|
|
||
| /// A programming language. | ||
| public struct SourceLanguage: Hashable, Codable, Comparable, Sendable { |
There was a problem hiding this comment.
Looks like you added Sendable conformance here, vs. the previous version in Sources/SwiftDocC/Model/SourceLanguage.swift. Was that intentional?
There was a problem hiding this comment.
Yes, you can see that that was made in 04a7964 after moving the code. Conforming to Sendable here is necessary for the stricter concurrency checks in the Swift 6 language mode that the same commit enables for this new target.
There was a problem hiding this comment.
I renamed the SourceLanguage file that was in SwiftDocC to CommonTypeExports so that git would produce a better diff for these changes.
|
|
||
| // A few common types and core functionality that's useable by all other targets. | ||
| .target( | ||
| name: "DocCCommon", |
There was a problem hiding this comment.
Similar to #1345 I added a "DocC" prefix to this target so as to not conflict with any other target in the toolchain.
|
@swift-ci please test |
Fix build after swiftlang/swift-docc#1331
2 participants
Bug/issue #, if applicable:
Summary
This extracts the
SourceLanguagetypeand theinto a new "Common" target.SynchronizedtypeThe purpose of this change is to make it easier for other new code to be written in other new special purpose targets. And to be able to adopt stricter compile time checks in some new code that we can't yet enable in the full
SwiftDocCtarget.Dependencies
None.
Testing
Nothing in particular. This isn't a user facing
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
[ ] Added tests./bin/testscript and it succeeded[ ] Updated documentation if necessary