Skip to content

[wasm] Respect leastValidPointerValue reported by the frontend -print-target-info #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[wasm] Respect leastValidPointerValue reported by the frontend -print-target-info #1991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Sources/SwiftDriver/Jobs/PrintTargetInfoJob.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ public struct FrontendTargetInfo: Codable {
/// The triple used for module names.
let moduleTriple: Triple

/// The least valid pointer value for the target.
let leastValidPointerValue: Int

/// The version of the Swift runtime that is present in the runtime
/// environment of the target.
var swiftRuntimeCompatibilityVersion: SwiftVersion?
Expand Down
9 changes: 3 additions & 6 deletions Sources/SwiftDriver/Jobs/WebAssemblyToolchain+LinkerSupport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,14 +157,11 @@ extension WebAssemblyToolchain {
// and memory footprint are significantly degraded. So we reserve the
// low addresses to use them as extra inhabitants by telling the lowest
// valid address to the linker.
// The value of lowest valid address, called "global base", must be always
// synchronized with `SWIFT_ABI_WASM32_LEAST_VALID_POINTER` defined in
// apple/swift's runtime library.
let SWIFT_ABI_WASM32_LEAST_VALID_POINTER = 4096
let leastValidPointerValue = targetInfo.target.leastValidPointerValue
commandLine.appendFlag(.Xlinker)
commandLine.appendFlag("--global-base=\(SWIFT_ABI_WASM32_LEAST_VALID_POINTER)")
commandLine.appendFlag("--global-base=\(leastValidPointerValue)")
commandLine.appendFlag(.Xlinker)
commandLine.appendFlag("--table-base=\(SWIFT_ABI_WASM32_LEAST_VALID_POINTER)")
commandLine.appendFlag("--table-base=\(leastValidPointerValue)")

// Delegate to Clang for sanitizers. It will figure out the correct linker
// options.
Expand Down