Skip to content

[Experiment] [BROKEN] Make stored captures trivial #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Experiment] [BROKEN] Make stored captures trivial #686

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38a45fe
WIP BROKEN: make stored captures trivial
milseman Jul 20, 2023
4268f7d
WIP: mock up a value capture index member
milseman Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Sources/_StringProcessing/Engine/MECapture.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ extension Processor {
struct _StoredCapture {
var range: Range<Position>? = nil

var value: Any? = nil
var value: Any? { nil }

var valueIndex: Array.Index? = nil

// An in-progress capture start
fileprivate var currentCaptureBegin: Position? = nil
Expand Down Expand Up @@ -72,7 +74,7 @@ extension Processor {
}

range = low..<idx
value = nil // TODO: cleaner IPI around this...
// value = nil // TODO: cleaner IPI around this...
currentCaptureBegin = nil
}

Expand All @@ -83,7 +85,8 @@ extension Processor {
_invariantCheck()
defer { _invariantCheck() }

self.value = value
fatalError()
// self.value = value
}
}
}
Expand Down