[Base64] Add new encoding options #1195
Open
+147
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proposal: #1156 |
itingliu
reviewed
Aug 20, 2025
| @@ -1804,17 +1804,65 @@ extension DataTests { | |||
| XCTAssertEqual(Data().base64EncodedData(), Data()) | |||
| } | |||
|
|
|||
| func test_base64Encode_allBytesSequentially() { | |||
There was a problem hiding this comment.
As you probably have noticed we've switched to swift-testing for all of our tests. Can you update this test to use swift-testing?
| @@ -2766,6 +2766,14 @@ extension Data { | |||
| public static let endLineWithCarriageReturn = Base64EncodingOptions(rawValue: 1 << 4) | |||
| /// When a maximum line length is set, specify that the line ending to insert should include a line feed. | |||
| public static let endLineWithLineFeed = Base64EncodingOptions(rawValue: 1 << 5) | |||
|
|
|||
| /// Use the base64url alphabet to encode the data | |||
| @available(FoundationPreview 6.2, *) | |||
There was a problem hiding this comment.
We'll need to update this to 6.3 since we've passed 6.2. Just so we don't forget we'll want to update the proposal too
fabianfett
force-pushed
the
ff-add-new-encoding-options
branch
from
31a85fa to
671392f
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for pitch