Improve temporary file location for atomic writes #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of mktemp when applicable
|
@swift-ci please test |
kperryua
approved these changes
Aug 21, 2025
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
_amkrtempis available (FOUNDATION_FRAMEWORKcases) we should use this before tryingmktempto create the temporary file location to preserve characteristics of the final destination like sandbox extensions. This patch adds a new use of_amkrtempfirst and falls back to the existingmktempif that fails to preserve existing behavior for failure cases. It also adds some infrastructure to include a debug description in file path errors so we can indicate the original_amkrtempfailure if both_amkrtempandmktempfail.