Replace withUnsafeContinuation with withCheckedContinuation in pendingWorkComplete #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion in DispatchQueue.pendingWorkComplete
sagar-vaholiya
requested review from
hborla,
ktoso,
mattmassicotte and
shahmishal
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the pendingWorkComplete helper on DispatchQueue to use withCheckedContinuation instead of withUnsafeContinuation.
Why
• withCheckedContinuation enforces at runtime that the continuation is resumed exactly once, helping catch mistakes early.
• Safer default for async APIs, consistent with modern Swift concurrency best practices.
• The original code included a TODO referencing apple/swift#74206, which is now resolved.
What’s changed
• Replaced withUnsafeContinuation with withCheckedContinuation in DispatchQueue.pendingWorkComplete.
• Added a test case (DispatchQueuePendingWorkTests) to verify that the function waits for queued work to complete before returning.
How it was tested
• Ran swift test locally; new test passes.
• Verified that the continuation is resumed correctly and that the async work is completed before returning.