Guidance document fix #9 #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
hborla
reviewed
Jun 16, 2024
Member
hborla
left a comment
hborla
left a comment
There was a problem hiding this comment.
I think this is a great start. I think we should also mention some of the "upcoming features" that are very high value to enable before enabling complete concurrency checking because they have the potential to eliminate a huge subset of the complete concurrency warnings. The two that come to mind are GlobalConcurrency and InferSendableFromCaptures.
ktoso
reviewed
Jun 17, 2024
ktoso
reviewed
Jun 17, 2024
ktoso
reviewed
Jun 17, 2024
ktoso
reviewed
Jun 17, 2024
ktoso
reviewed
Jun 17, 2024
Contributor
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Good start, some minor wording ideas; pick or not, your call :)
ktoso
approved these changes
Jun 17, 2024
mattmassicotte
force-pushed
the
mattmassicotte/guidance
branch
from
ec7fe05 to
b9840e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've begun work on a guidance document. Currently, this mostly lines up with the content from the "Migrate your app to Swift 6" WWDC video. However, I did get into the leaf vs root module problem.
I also have a lot more to do here, but I thought it would be useful to get feedback early. Especailly since @dempseyatgithub had some ideas too.
#46