[SwiftBuild] Use hostBuildTool product type for build plugin targets
#8936
Conversation
…rgets Match how macros are handled and use the `hostBuildTool` product type. rdar://155792370
hamishknight
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
MaxDesiatov
changed the title
hostBuildTool product type for SPM build plugin targetshostBuildTool product type for build plugin targets
| @@ -39,7 +39,7 @@ extension PackagePIFProjectBuilder { | |||
| let pluginTargetKeyPath = try self.project.addTarget { _ in | |||
| ProjectModel.Target( | |||
| id: pluginModule.pifTargetGUID, | |||
| productType: .executable, | |||
| productType: .hostBuildTool, | |||
There was a problem hiding this comment.
suggestion: can we add an automated tests to ensure we don't regress in the future?
There was a problem hiding this comment.
As far as I could tell, we don't really have any existing unit tests for this logic, only integration tests, unless I'm overlooking something?
There was a problem hiding this comment.
I agree adding more test coverage would be beneficial.
@pmattos Did you add any tests for the PIF generation in libSwiftPM?
There was a problem hiding this comment.
No, I didn't... only those on the Xcode side of things.
We do have XCBuild PIF tests that we plan to port over eventually.
There was a problem hiding this comment.
Is there a GitHub issue tracking the work of porting the tests?
There was a problem hiding this comment.
I don't think so Sam... but I just added one: #8980
|
@hamishknight Please just wait for that other PR to land, before merging this. Thanks! |
|
@swift-ci please test |
Match how macros are handled and use the
hostBuildToolproduct type.rdar://155792370