[Swift Build] Default to the package's declared deployment target if none is explicitly specified #9139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…none is explicitly specified
owenv
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
| let hostArch: String | ||
| #if arch(arm64) | ||
| hostArch = "arm64" | ||
| #else |
There was a problem hiding this comment.
nit: else-if-x86_64 would be better
jakepetroules
approved these changes
Sep 16, 2025
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
dschaefer2
approved these changes
Sep 18, 2025
|
Not sure how I broke the self-hosted plugin tests but those are reliably failing with this patch... |
|
@swift-ci test self-hosted |
|
@swift-ci test self hosted |
owenv
force-pushed
the
owenv/deployment-targets
branch
from
4c8704d to
ab11e91
Compare
|
@swift-ci test self hosted |
owenv
force-pushed
the
owenv/deployment-targets
branch
from
ab11e91 to
570bbea
Compare
|
@swift-ci test self hosted |
owenv
force-pushed
the
owenv/deployment-targets
branch
from
570bbea to
749c8cb
Compare
|
@swift-ci test self hosted |
GitHubismae
approved these changes
Sep 21, 2025
|
@swift-ci test |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to an unversioned triple if the user hasn't provided one so we don't raise the deployment target to a version the package may not support
closes #9095