Use SwiftBuild API to reliably compute built artifacts #9143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
owenv
force-pushed
the
owenv/artifacts
branch
from
a5a1f06 to
3068ec7
Compare
jakepetroules
approved these changes
Sep 18, 2025
| } | ||
| var name = target.name | ||
| // FIXME: We need a better way to map between SwiftPM target/product names and PIF target names | ||
| if pifTargetName.hasSuffix("-product") { |
There was a problem hiding this comment.
This seems like an accident waiting to happen :S
Should we have some more API surface here?
There was a problem hiding this comment.
I think so, but I haven't decided what it should look like yet
cmcgee1024
approved these changes
Sep 18, 2025
|
@swift-ci test |
owenv
force-pushed
the
owenv/artifacts
branch
from
3068ec7 to
b43f345
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
|
@swift-ci test self hosted |
1 similar comment
|
@swift-ci test self hosted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on swiftlang/swift-build#801
By querying the build system for the artifacts, we ensure we only report any we will actually produce in the current build. At the same time, pull in an alternative fix for #9121 which restores the original behavior of the native build system when considering products in dependency packages.