Skip to content

Conversation

omochi
Copy link
Contributor

@omochi omochi commented Sep 22, 2025

Make the dump-package command output defaultLocalization

Motivation:

The dump-package command did not output defaultLocalization, which meant that manifests containing this information could not be fully represented in the dumped JSON.

Modifications:

Fixed the implementation so that defaultLocalization is now included in the output of the dump-package command.

Result:

Running swift package dump-package will now correctly include the defaultLocalization field in its JSON output.

@omochi
Copy link
Contributor Author

omochi commented Sep 22, 2025

@swift-ci test

1 similar comment
@omochi
Copy link
Contributor Author

omochi commented Sep 23, 2025

@swift-ci test

Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the test failures are cleaned up

@@ -1,8 +1,9 @@
// swift-tools-version:5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tools-version bump here might have broken a handful of unrelated tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. I’ll look into it on my end.

@omochi
Copy link
Contributor Author

omochi commented Sep 24, 2025

@owenv

To specify defaultLocalization, it was necessary to advance the swift-tools-version directive,
but doing so caused the package API to change, which seemed to have a large impact.

Since the dump-package command and "Dependency Resolution" are unrelated topics,
I separated the fixture into a dedicated one.

The contents of the new fixture are almost the same as the original,
but I simplified the configuration from involving 4 packages down to 2.

@omochi
Copy link
Contributor Author

omochi commented Sep 24, 2025

@swift-ci test

@omochi omochi requested a review from owenv September 24, 2025 10:59
@bripeticca
Copy link
Contributor

@swift-ci please test windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants