-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Make the dump-package
command output defaultLocalization
#9170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@swift-ci test |
1 similar comment
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the test failures are cleaned up
@@ -1,8 +1,9 @@ | |||
// swift-tools-version:5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tools-version bump here might have broken a handful of unrelated tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. I’ll look into it on my end.
To specify Since the The contents of the new fixture are almost the same as the original, |
@swift-ci test |
@swift-ci please test windows |
Make the
dump-package
command output defaultLocalizationMotivation:
The
dump-package
command did not outputdefaultLocalization
, which meant that manifests containing this information could not be fully represented in the dumped JSON.Modifications:
Fixed the implementation so that
defaultLocalization
is now included in the output of thedump-package
command.Result:
Running
swift package dump-package
will now correctly include thedefaultLocalization
field in its JSON output.