Disable optimization to work around a compiler bug #9178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in the Swift rebranch that prevents some functions from being optimized in a way that the assembler can handle. This temporarily disables optimizations for these functions until a permanent solution is implemented. Bug: swiftlang/llvm-project#11377
Steelskin
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
rconnell9 and
shawnhyam
as code owners
|
@swift-ci please smoke test |
owenv
approved these changes
Sep 23, 2025
jakepetroules
approved these changes
Sep 23, 2025
|
@swift-ci please test |
|
@swift-ci please test windows |
bripeticca
approved these changes
Sep 25, 2025
|
Going to merge this to unblock rebranch (CC: @AnthonyLatsis @bnbarham) |
Steelskin
added a commit
to Steelskin/swift-package-manager
that referenced
this pull request
Oct 7, 2025
The issue has been fixed in the compiler so the workaround is no longer necessary. Bug: swiftlang/llvm-project#11377
Steelskin
added a commit
to Steelskin/swift-package-manager
that referenced
this pull request
Oct 7, 2025
The issue has been fixed in the compiler so the workaround is no longer necessary. Reverts swiftlang#9178. Bug: swiftlang/llvm-project#11377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily disable optimizations for some functions.
Motivation:
There is a bug in the Swift rebranch that prevents some functions from being optimized in a way that the assembler can handle. This temporarily disables optimizations for these functions until a permanent solution is implemented.
Bug: swiftlang/llvm-project#11377
Modifications:
Disable optimizations on Windows for problematic functions.
Result:
The project builds for the Swift rebranch.