Skip to content

fix modulemap generation on window using swift-build #9179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix modulemap generation on window using swift-build #9179

wants to merge 1 commit into from

Conversation

daveinglis
Copy link
Contributor

  • Windows paths need to be escaped

@daveinglis
Copy link
Contributor Author

@swift-ci test

@daveinglis
fix modulemap generation on window using swift-build
b9af1d3 
- Windows paths need to be escaped
@daveinglis
Copy link
Contributor Author

@swift-ci test

@daveinglis
Copy link
Contributor Author

@swift-ci test windows

@bkhouri
Copy link
Contributor

bkhouri commented Sep 23, 2025 •
edited
Loading

Are there any tests we can enable, or remove "withKnownIssue" from

jakepetroules
jakepetroules approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@jakepetroules jakepetroules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I'd like to see this modulemap generation be moved down into the Swift Build layer in the fullness of time, PIF generation does not at all seem like the right place for it. This is a historical artifact.

@bripeticca
Copy link
Contributor

@swift-ci please test self hosted windows

1 similar comment
@daveinglis
Copy link
Contributor Author

@swift-ci please test self hosted windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakepetroules jakepetroules jakepetroules approved these changes

@owenv owenv owenv approved these changes

@bkhouri bkhouri bkhouri approved these changes

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

@rconnell9 rconnell9 Awaiting requested review from rconnell9 rconnell9 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daveinglis @bkhouri @bripeticca @jakepetroules @owenv