Skip to content

Revert "Disable some optimizations on Windows" #9225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

Revert "Disable some optimizations on Windows" #9225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cc1aa0
Revert "Disable some optimizations on Windows"
Steelskin Oct 7, 2025
3e8730e
Revert the reverted whitespace changes
Steelskin Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions Sources/PackageLoading/ManifestLoader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,11 +679,6 @@ public final class ManifestLoader: ManifestLoaderProtocol {
}

/// Helper method for evaluating the manifest.
// TODO: Optimizations are disabled to work around a compiler bug. Remove this attribute when the bug is fixed.
// See https://github.com/swiftlang/llvm-project/issues/11377 for details.
#if os(Windows)
@_optimize(none)
#endif
func evaluateManifest(
at manifestPath: AbsolutePath,
vfsOverlayPath: AbsolutePath? = nil,
Expand Down
5 changes: 0 additions & 5 deletions Sources/PackageRegistryCommand/PackageRegistryCommand+Publish.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,11 +461,6 @@ enum PackageArchiveSigner {
}

enum PackageArchiver {
// TODO: Optimizations are disabled to work around a compiler bug. Remove this attribute when the bug is fixed.
// See https://github.com/swiftlang/llvm-project/issues/11377 for details.
#if os(Windows)
@_optimize(none)
#endif
static func archive(
packageIdentity: PackageIdentity,
packageVersion: Version,
Expand Down
5 changes: 0 additions & 5 deletions Sources/Workspace/Workspace+Prebuilts.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,11 +422,6 @@ extension Workspace {
return hash == checksum
}

// TODO: Optimizations are disabled to work around a compiler bug. Remove this attribute when the bug is fixed.
// See https://github.com/swiftlang/llvm-project/issues/11377 for details.
#if os(Windows)
@_optimize(none)
#endif
func downloadPrebuilt(
workspace: Workspace,
package: PrebuiltPackage,
Expand Down