Add-dependency command updates all manifests #9285
Conversation
|
There is still needing tests + option to specify the manifest files a user wants to add-dependencies to. |
|
Furthermore, I think that on top of add-dependency, other similar subcommands, such as add-target and add-product, should also support this logic |
| // Find version specific manifests | ||
| do { | ||
| let packageContents = try fileSystem.getDirectoryContents(packagePath) | ||
| let regexManifestFile = try! RegEx(pattern: #"^Package@swift-(\d+)(?:\.(\d+))?(?:\.(\d+))?.swift$"#) |
There was a problem hiding this comment.
question: Is there some reusable regex or function that can find all of the package manifests?
There was a problem hiding this comment.
No, sadly there is not a reusable regex. Furthermore, the only function that is used for finding package manifests only returns one (which is required for the manifest loader, as you would not load multiple manifests)
|
This change looks good to me. If there were some tests I think that it can be flipped to "ready for review." |
johnbute
requested review from
bkhouri,
bripeticca,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
|
@swift-ci please test |
2 participants
Add-dependency will update all manifest files in a swift package
Motivation:
#9248
Modifications:
Essentially, just added a function to query all possible manifest files, then apply edits to each one.
Result:
Now, add-dependency can edit multiple manifests at the same time such as swift argument parser.