Use a custom AttachableImageFormat type instead of directly relying on UTType.
#1203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on `UTType`. This PR creates a platform-agnostic type to represent image formats for image attachments instead of relying directly on `UTType`. The implementation still requires `UTType` on Apple platforms, but on non-Apple platforms we can use the same type to represent those platforms' platform-specific image format enums (e.g. on Windows, it can box `CLSID`.) This reduces the platform-specific API surface area for image attachments.
grynspan
requested review from
stmontgomery,
briancroom and
suzannaratcliff
as code owners
grynspan
added
the
attachments/activities
|
@swift-ci test |
grynspan
commented
Jul 7, 2025
| // the preferred name's path extension. | ||
| let pathExtension = (preferredName as NSString).pathExtension | ||
| if !pathExtension.isEmpty, | ||
| let contentType = UTType(filenameExtension: pathExtension, conformingTo: .image), |
There was a problem hiding this comment.
Note to self: on Windows, ImageCodecInfo::FilenameExtension should help us here. Windows does not have hierarchical type declarations (does it?)
There was a problem hiding this comment.
Pointer to a null-terminated string that contains all file-name extensions associated with the codec. The extensions are separated by semicolons.
briancroom
reviewed
Jul 8, 2025
briancroom
reviewed
Jul 8, 2025
briancroom
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a platform-agnostic type to represent image formats for image attachments instead of relying directly on
UTType. The implementation still requiresUTTypeon Apple platforms, but on non-Apple platforms we can use the same type to represent those platforms' platform-specific image format enums (e.g. on Windows, it can boxCLSID.) This reduces the platform-specific API surface area for image attachments.Checklist: