Skip to content

[WIP, DNM] Windows image attachments #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

[WIP, DNM] Windows image attachments #1245

wants to merge 21 commits into from
+1,022 −9

Conversation

grynspan
Copy link
Contributor

Add support for attaching images on Windows if they are instances of types we can convert to Gdiplus::Image. Due to current limitations on Swift/C++ interop, it's not possible to attach a Gdiplus::Image directly (they get brought in as the nefarious OpaquePointer type) but you can attach an HBITMAP or HICON. More types to follow.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added this to the Swift 6.x (main) milestone Jul 30, 2025
@grynspan grynspan added enhancement New feature or request windows 🪟 Windows support attachments/activities 🖇️ Work related to attachments and/or activities labels Jul 30, 2025
@grynspan
Copy link
Contributor Author

Proper support for GDI+ is blocked by swiftlang/swift#83408.

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test Windows

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan requested a review from briancroom July 30, 2025 23:03
@grynspan
Copy link
Contributor Author

@swift-ci test Windows

compnerd
compnerd reviewed Jul 31, 2025
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that this is a great start!

@grynspan
Copy link
Contributor Author

Ooh, fun SILGen crash.

@grynspan
Copy link
Contributor Author

Tracking the SIL issue here: swiftlang/swift#83452

@grynspan
Copy link
Contributor Author

@swift-ci test Windows

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test Linux

@grynspan
Copy link
Contributor Author

@swift-ci test macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd left review comments

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery will be requested when the pull request is marked ready for review stmontgomery is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff will be requested when the pull request is marked ready for review suzannaratcliff is a code owner

Assignees

@compnerd compnerd

@grynspan grynspan

Labels
attachments/activities 🖇️ Work related to attachments and/or activities enhancement New feature or request windows 🪟 Windows support
Projects
None yet
Milestone
Swift 6.x (main)
Development

Successfully merging this pull request may close these issues.
3 participants
@grynspan @compnerd @briancroom