Implement an overload of confirmation() that takes an unbounded range.
#598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unbounded ranges are not meaningful when used with `confirmation()` because _any_ confirmation count matches. As well, the `...` operator produces an instance of `UnboundedRange` which is a non-nominal type and cannot conform to `RangeExpression`. It may be non-obvious to a developer why `...` doesn't work as the `expectedCount` argument to that function when other range operators work as expected. This PR implements a stub overload of `confirmation()` that takes an unbounded range. The stub overload is marked unavailable and cannot be called.
grynspan
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
stmontgomery and
suzannaratcliff
as code owners
|
@swift-ci please test |
grynspan
commented
Aug 2, 2024
| case let errorCode: | ||
| let error = Win32Error(rawValue: errorCode) | ||
| fatalError("unexpected error when getting environment variable '\(name)': \(error) (\(errorCode))") | ||
| fatalError("Unexpected error when getting environment variable '\(name)': \(error) (\(errorCode))") |
There was a problem hiding this comment.
Drive-by formatting tweak.
grynspan
commented
Aug 2, 2024
|
|
||
| default: | ||
| fatalError("Unsupported keyword \(whenKeyword) passed to \(#function)") | ||
| fatalError("Unsupported keyword \(whenKeyword) passed to \(#function). Please file a bug report at https://github.com/swiftlang/swift-testing/issues/new") |
There was a problem hiding this comment.
Drive-by amendment to fatal error message.
|
@swift-ci please test |
|
Self-reviewing (tsk.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbounded ranges are not meaningful when used with
confirmation()because any confirmation count matches. As well, the...operator produces an instance ofUnboundedRangewhich is a non-nominal type and cannot conform toRangeExpression. It may be non-obvious to a developer why...doesn't work as theexpectedCountargument to that function when other range operators work as expected.This PR implements a stub overload of
confirmation()that takes an unbounded range. The stub overload is marked unavailable and cannot be called.Example usage:
Generated diagnostic:
As a reminder, using a range expression with
confirmation()is an experimental feature and has not been API-reviewed.Checklist: