Skip to content

Don't define swt_getWASIVersion() on non-WASI. #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2024
Merged

Don't define swt_getWASIVersion() on non-WASI. #632

merged 1 commit into from
Aug 23, 2024

Conversation

@grynspan
Copy link
Contributor

@grynspan grynspan commented Aug 21, 2024 •
edited
Loading

Don't define swt_getWASIVersion() on non-WASI. Oops. :)

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Don't define swt_getWASIVersion() on non-WASI.
e1932f4 
Don't define `swt_getWASIVersion()` on non-WASI. Oops. :)
@grynspan grynspan added bug 🪲 Something isn't working wasi/wasm 🧭 WebAssembly support swift-6.1 labels Aug 21, 2024
@grynspan grynspan self-assigned this Aug 21, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

Base automatically changed from main-next to main August 22, 2024 13:39
@grynspan
Copy link
Contributor Author

Self-reviewing.

@grynspan grynspan added the self-reviewed PR was self-reviewed by a code owner label Aug 23, 2024
@grynspan grynspan merged commit 9773daa into main Aug 23, 2024
@grynspan grynspan deleted the jgrynspan/no-define-swt_getWASIVersion branch August 23, 2024 18:59
@grynspan grynspan added this to the Swift 6.1 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels

bug 🪲 Something isn't working self-reviewed PR was self-reviewed by a code owner wasi/wasm 🧭 WebAssembly support

Projects

None yet

Milestone

Swift 6.1.0

Development

Successfully merging this pull request may close these issues.

1 participant

@grynspan