Delete reference to simpleTypeSpecifier #765
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
requested review from
stmontgomery,
grynspan,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
This was referenced Oct 15, 2024
|
@swift-ci please test |
|
It looks like this will break compatibility with the swift-syntax-600.0.x tag that the package depends on. Is there a way we can stage this change such that it will remain compatible with earlier tags of swift-syntax? Alternatively, could we first get the upstream change included in a swift-syntax tag, then update the package dependency to reference that tag, then land this change? |
|
Should be possible to do something like: #if !canImport(SwiftSyntax, _version: N)
// old code here
#endifWhere |
grynspan
reviewed
Oct 15, 2024
Co-authored-by: Jonathan Grynspan <jgrynspan@apple.com>
|
@swift-ci please test |
|
Based on a side discussion, I think we can close this PR? |
|
Closing this PR. Reworked swiftlang/swift-syntax#2876 to avoid api break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update as per swift-syntax changes in swiftlang/swift-syntax#2876