[AST] Remove UnresolvedType #84634
Merged
[AST] Remove UnresolvedType #84634
+95
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
xymus,
hborla,
xedin,
slavapestov,
adrian-prantl,
bnbarham,
rintaro,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro and
tshortli
as code owners
|
@swift-ci please SourceKit stress test |
|
@swift-ci please test |
slavapestov
approved these changes
Oct 2, 2025
xedin
approved these changes
Oct 2, 2025
These should be unreachable now.
Add `hasBareError` and `isBareErrorType` to check whether a type is an ErrorType without an underlying original type (i.e prints as `_`).
…Type` This means we now either produce a bare ErrorType, or an ErrorType with a generic parameter original type for a generic parameter hole. We ought to further consolidate this logic by sinking the generic parameter original type replacement into `simplifyType` itself, but I'm leaving that for a future patch since it affects completion results and I want to try keep this close to NFC.
We have now removed all uses of this type.
hamishknight
force-pushed
the
fish-whisperer
branch
from
335cdaa to
954b08c
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the remaining uses in
simplifyType/resolveType, producing an ErrorType instead.