Windows: Pass full target triple to build #85007
Open
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CMAKE_Swift_COMPILER_TARGET` takes the full target triple, not the module triple. This probably doesn't affect Windows, but will/does affect availability on Android resulting in Foundation failing to build due to `error: 'getgrnam_r' is only available in Android 24 or newer`.
`CMAKE_Swift_COMPILER_TARGET` is set up by `Build-CMakeProject`. We shouldn't need to pass it into the volatile build explicitly.
|
@swift-ci please test |
|
@swift-ci please build Windows Toolchain |
|
@swift-ci please build toolchain Windows platform |
|
@swift-ci please build toolchain Windows ARM64 platform |
compnerd
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_Swift_COMPILER_TARGETtakes the full target triple, not the module triple. The module triple will be the same on platforms that don't use availability, but on platforms that do (or will) like Android, this will result in availability issues, like the one we are seeing on the Windows CI,error: 'getgrnam_r' is only available in Android 24 or newer.Also removing the extra
CMAKE_Swift_COMPILER_TARGETvalue passed to the volatile build.Build-CMakeProjectis already computing that with the same value.