-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Add experimental feature flag EmbeddedExistentials #85009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental feature flag EmbeddedExistentials #85009
Conversation
This flag can be used to gradually add the functionility that will allow use of protocol values in embedded mode.
|
@swift-ci smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| is InitExistentialValueInst, | ||
| is ExistentialMetatypeInst: | ||
| throw Diagnostic(.embedded_swift_existential_type, instruction.operands[0].value.type, at: instruction.location) | ||
| if !context.options.enableEmbeddedSwiftExistentials { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong indentation
| } | ||
|
|
||
| var enableEmbeddedSwiftExistentials: Bool { | ||
| hasFeature(.EmbeddedExistentials) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here, too
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
@swift-ci smoke test macOS |
|
@swift-ci clean smoke test |
This flag can be used to gradually add the functionility that will allow use of protocol values in embedded mode.