[CoroutineAccessors] Fix overriding. #85013
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lift this function and enum out of the body of OpaqueReadOwnershipRequest::evaluate .
Prefix it "direct" to indicate that it doesn't consider supertypes.
When storage overrides a supertype's storage, the storage's opaque access must be via the same mechanism as the supertype. rdar://156627653
In preparation for making the implementation more than a one-liner.
Before the feature is enabled, a var decl for which a reading accessor is implemented via _read still had as its opaque accessor a getter (unless it's marked @_borrowed, it's noncopyable, or it has a lifetime dependency). So when that `_read` is replaced with a `read`/`yielding borrow`, it is still necessary to emit a getter. And for back deployment it is still necessary to provide a default override of the getter in terms of the `read`. rdar://149352519
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #84472 .
Before the feature is enabled, a var decl for which a reading accessor is implemented via
_readstill had as its opaque accessor a getter (unless it's marked@_borrowed, it's noncopyable, or it has a lifetime dependency). So when that_readis replaced with aread/yielding borrow, it is still necessary to emit a getter. And for back deployment it is still necessary to provide a default override of the getter in terms of theread.rdar://149352519