Skip to content

Don’t redundantly diagnose key path components #85018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
+5 −4
Merged

Don’t redundantly diagnose key path components #85018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/Sema/PreCheckTarget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2642,7 +2642,9 @@ void PreCheckTarget::resolveKeyPathExpr(KeyPathExpr *KPE) {
if (isa<ParenExpr>(expr) || isa<TupleExpr>(expr)) {
DE.diagnose(expr->getLoc(),
diag::expr_string_interpolation_outside_string);
} else {
} else if (!isa<ErrorExpr>(expr)) {
// If we have an `ErrorExpr`, we've probably already emitted a
// diagnostic explaining it.
DE.diagnose(expr->getLoc(),
diag::expr_swift_keypath_invalid_component);
}
Expand Down
5 changes: 2 additions & 3 deletions test/expr/unary/keypath/keypath.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1186,8 +1186,7 @@ func f_56996() {
_ = \Int.byteSwapped.init() // expected-error {{static member 'init()' cannot be used on instance of type 'Int'}}
_ = \Int // expected-error {{key path must have at least one component}}
_ = \Int? // expected-error {{key path must have at least one component}}
_ = \Int. // expected-error {{invalid component of Swift key path}}
// expected-error@-1 {{expected member name following '.'}}
_ = \Int. // expected-error {{expected member name following '.'}}
}

// https://github.com/apple/swift/issues/55805
Expand Down Expand Up @@ -1439,4 +1438,4 @@ func testKeypathWithTypeReference() {
_ = \S.Q.Type.i // okay

_ = \S.Type.Q // expected-error {{key path cannot refer to type 'Q'}}
}
}