[ClangImporter] add implicit import of Swift for __ObjC module
#85023
+57
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any safe wrapper expansion originating in a bridging header would fail typechecking because the `__ObjC` module doesn't import the standard implicit imports. This is because the main module is not available to inherit implicit imports from when the `__ObjC` module is created. We don't need all of the implicit modules for safe wrappers, so import `Swift` specifically. rdar://163078116
hnrklssn
requested review from
Xazax-hun,
beccadax,
egorzhdan,
fahadnayyar,
ian-twilightcoder,
j-hui,
susmonteiro and
zoecarver
as code owners
|
@swift-ci please smoke test |
This prevents it from being loaded correctly later.
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
I think we can ignore the earlier failing run, since the newer run passed (and the smoke test also failed previously) |
|
@swift-ci please test macos platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any safe wrapper expansion originating in a bridging header would fail typechecking because the
__ObjCmodule doesn't import the standard implicit imports. This is because the main module is not available to inherit implicit imports from when the__ObjCmodule is created. We don't need all of the implicit modules for safe wrappers, so importSwiftspecifically.rdar://163078116