[CSOptimizer] Update unary call favoring to include resolved member r… #85151
+47
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
…eferences Update special favoring logic for unlabeled unary calls to support non-overloads member references in argument positions. The original hack missed a case where a type of a member is known in advance (i.e. a property without overloads) because there as another hack (shrink) for that. This helps in situations like `Double(x)` where `x` is a property of some type that is referenced using an implicit `self.` injected by the compiler. Resolves: rdar://161419917
|
@swift-ci please test |
|
@swift-ci please test source compatibility debug |
|
@swift-ci please test macOS platform |
hamishknight
approved these changes
Oct 27, 2025
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eferences
Update special favoring logic for unlabeled unary calls to support non-overloads member references in argument positions.
The original hack missed a case where a type of a member is known in advance (i.e. a property without overloads) because there as another hack (shrink) for that.
This helps in situations like
Double(x)wherexis a property of some type that is referenced using an implicitself.injected by the compiler.Resolves: rdar://161419917