-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Platform: add DirectX.Direct2D module to WinSDK
#85532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
swiftlang/swift-docc#1352 |
|
@swift-ci please build toolchain Windows platform |
|
@swift-ci please build toolchain Windows ARM64 platform |
|
@swift-ci please test Windows platform |
|
@swift-ci please build toolchain Windows ARM64 platform |
|
@swift-ci please build toolchain Windows platform |
|
@swift-ci please test Windows platform |
|
@swift-ci please build toolchain Windows ARM64 platform |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test macOS platform |
|
The ARM64 failure is weird - I think that it is picking up the wrong version of the script somehow 🤔 (CC: @shahmishal) |
Adding Direct2D to WinSDK. I tested the change locally and was able to use Direct2D types.
cc: @compnerd
Fixes #57723.
For more context, I was trying to create a shim to expose Direct2D to my Swift package but ran into this assertion (same thing that referenced issue):
I tried with a variety of toolchains (all with assertions enabled) and they all presented the same issue. I figured that the issue could be related with that type already present in WinSDK, so I decided to try to add the Direct2D module to WinSDK and I got things working.