[Sema] A couple of binding-related crasher fixes #85538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we don't produce unnecessary diagnostics while still allowing things like cursor info to work. No test change since it's covered by the next commit.
Make sure we preserve the result expression for an out-of-place `return`, or a non-`nil` result in an initializer. This ensures we can still provide semantic functionality from them and fixes a crash where we would fail to type-check a binding.
Make sure we invalidate when we initially visit the ExprPattern to ensure that we don't run into issues when generating constraints for a `where` clause before the constraints for the ExprPattern. We ought to change the constraint generation there to use a conjunction to ensure that the pattern is solved before the `where` clause, but I want to keep this as a quick low risk fix that we can cherry-pick. I'll switch it to a conjunction in a follow-up.
This appears unnecessary and incorrectly meant the ErrorExpr would be placed outside the condition, meaning we could find the binding in its own initializer.
hamishknight
requested review from
bnbarham,
hborla,
rintaro,
slavapestov and
xedin
as code owners
Contributor
Author
|
@swift-ci please test macOS |
Contributor
Author
|
@swift-ci please smoke test Linux |
Contributor
Author
|
@swift-ci please test Windows |
xedin
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning on adding an assert that ensures we don't type-check bindings independently of their closure context, the fuzzer found crashers for the following cases, which with some modification can also crash even without the assert. Fix up these cases such that we can land the assert without regressing anything.
whereclause before we've assigned them a type