Use svgo float #16
Open
Use svgo float #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just created a similar cli. Since I'm not to proficient in go it took a little while. Is it possible to merge the cli part? I'd imagine many others are doing this same exercise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use the upstream
github.com/ajstarks/svgo/floatpackage for the SVG generation instead of your fork. It seems like the tests produce the same output.I don't know if you would be interested, it seems like the discussions on the svgo issues about this led to nowhere and died out ?
I also added a simple cli tool based on the readme example to generate files based on a json configuration file to facilitate testing of small variations.