Skip to content

Conversation

@cogrow4
Copy link

@cogrow4 cogrow4 commented Oct 13, 2025

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • [ x] A convincing reason for adding this feature (it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2025

CLA assistant check
All committers have signed the CLA.

@michilyy
Copy link
Contributor

Hello @cogrow4
I have some questions regarding the Dockerfile.
You copy the entire swingmusic source code into the workdir.
Could you please explain why you changed from the old wheel install to a source install?

@cogrow4
Copy link
Author

cogrow4 commented Oct 23, 2025

Hello @cogrow4 I have some questions regarding the Dockerfile. You copy the entire swingmusic source code into the workdir. Could you please explain why you changed from the old wheel install to a source install?

Oh sorry, I forgot to change it back to wheel after I was testing some builds. I just had some issues with wheel locally. I can just change the dockerfile back.

@michilyy
Copy link
Contributor

Could you please state which issues you encountered when using the wheels locally.

@michilyy michilyy self-requested a review October 23, 2025 19:24
@cogrow4 cogrow4 marked this pull request as draft October 23, 2025 22:10
Updated Dockerfile to copy wheels directory and install dependencies from it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants