Use Rails asset pipeline URL functions to load icon font if they exist #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good one, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on fixing some 404 errors in a Rails app for work that uses jQuery-contextMenu. We're using the asset pipeline for fonts, which appends digest strings to their filenames. This causes this library's stylesheets to look for fonts in the wrong place.
This PR uses the asset pipeline's Sass helper functions if they exist to ensure that the correct font URLs end up in the compiled CSS in Rails apps. If those functions don't exists, e.g. when using Gulp to build CSS, it'll use
url().A similar approached is used by Slick Carousel to make their stylesheets' font URLs Rails friendly: https://github.com/kenwheeler/slick/blob/master/slick/slick-theme.scss#L33-L40