Make the modal layer let click events passthrough #760
+38
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With useModal set to false, uses document.addeventlistener in capture mode rather than an invisible layer. Note that this probably breaks on older browsers, and some features or options might not work anymore. useModal is set to true by default, and should behave just like before.
Speedphoenix
changed the title
|
MErged in #780, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
useModaloption, defaults totruefor the existing behaviour.With
useModalset to false, rather than creating a hidden layer behind the contextmenu to capture closing clicks, uses document.addeventlistener in capture mode.This allows for propagating click events when clicking in empty space to close the contextmenu (before, only the
mousedownevent waspropagated, and noclickwas sent since the followingmouseupwould not be on the same element)Note
useModal = falsemight break on older browsers, or some features might not work with it anymore (unlikely though).