Skip to content

fix(docs): fix dialog markup on dialog text content and button intendation #6206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix(docs): fix dialog markup on dialog text content and button intendation #6206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fbe8bd6
chore(docs): added `<p>`-tag around dialog content in Default Templat…
bucknatt Sep 11, 2025
006654f
fix(docs): added changeset
bucknatt Sep 11, 2025
bc66bca
fix(tests): wait in popopover test for container to be not.be.visible
bucknatt Sep 12, 2025
598da0d
Merge branch 'main' into 6180-fix-dialog-markup
bucknatt Sep 12, 2025
c9584ed
chore(styles): updated button intendiation to be seperated on two lin…
bucknatt Sep 18, 2025
6eb0fba
Merge branch 'main' into 6180-fix-dialog-markup
bucknatt Sep 18, 2025
287f769
chore(styles): reverted changes to flex-direction
bucknatt Sep 18, 2025
e1925fa
Merge branch 'main' into 6180-fix-dialog-markup
alionazherdetska Sep 25, 2025
f59d637
fix(docs): reverted changes in cypress e2e, updated changeset
bucknatt Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/four-monkeys-buy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@swisspost/design-system-documentation': patch
---

Improved `dialog` component accessibility by adding proper paragraph markup around text content.
2 changes: 1 addition & 1 deletion packages/documentation/src/stories/components/dialog/dialog.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ const Template = {
<form method="dialog" class="dialog-grid">
${postDialogIcon}
<h3 class="dialog-header">${args.title}</h3>
<div class="dialog-body">${args.content}</div>
<div class="dialog-body"><p>${args.content}</p></div>
<div class="dialog-controls">${getControls()}</div>
${postDialogCloseButton}
</form>
Expand Down