Fixes issue with using multiple params and columns#1
Open
gitsno wants to merge 1 commit intoswkruger:masterfrom
Open
Fixes issue with using multiple params and columns#1gitsno wants to merge 1 commit intoswkruger:masterfrom
gitsno wants to merge 1 commit intoswkruger:masterfrom
Conversation
…ams loop to exit once a param has been replaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this widget I found that if I had more than one column that needed to get HTML from an underlying entity attribute (so I had two parameters and two columns getting values from those parameters), then only the last parameter was used. Other parameters would be ignored and the parameter reference (eg. ${myattribute}) would be displayed in the column instead of the HTML attribute value.
In this pull request I have modified the loop that processes the params to exit once a param value has been used to replace the column value.
I don't know if the intention was to be able to replace multiple params in the Html to apply for a column - if so this change will not do that, but that was also not working prior to this change.