Skip to content

Conversation

@Alrobbertz
Copy link
Member

No description provided.

@Alrobbertz Alrobbertz changed the title Update Requirements Update Processing Lambda to Support PADRE Craft Nov 13, 2025
@Alrobbertz Alrobbertz marked this pull request as ready for review November 14, 2025 15:54
Copilot AI review requested due to automatic review settings November 14, 2025 15:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the PADRE Craft instrument to the file processing Lambda function. The changes enable processing of PADRE Craft CSV data files alongside existing instrument support, with improved handling of calibration outputs that may include None values.

Key Changes:

  • Added PADRE Craft instrument package dependency and test data
  • Refactored file calibration logic to return lists of files and handle None values
  • Updated file metadata tracker with improved error handling, type hints, and documentation
  • Modified CI/CD workflow and README to demonstrate PADRE-specific testing

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
lambda_function/tests/test_data/test_craft_event.json New test event for PADRE Craft S3 bucket triggering Lambda processing
lambda_function/tests/test_data/padre_get_CUBEADCS_GEN2_OP_STATUS_APP_Data_1761936771334_1762106179414.csv Sample PADRE Craft CSV telemetry data for testing
lambda_function/src/file_processor/file_processor.py Major refactoring: added list-based file returns, None value handling, CSV support, keyword arguments for metatracker, and improved documentation
lambda_function/padre-requirements.txt Added padre_craft package dependency
README.md Updated docker command examples with multi-line formatting and corrected repository link
.github/workflows/calibration.yml Updated workflow to test PADRE mission with new base image and test data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Alrobbertz Alrobbertz merged commit a52d993 into swxsoc:main Nov 14, 2025
1 of 2 checks passed
@Alrobbertz Alrobbertz deleted the add_support_for_padre_craft branch November 14, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants