Skip to content

Model.all should return a new collection each time. #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaughankg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Model.all should return a new collection each time. #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adc4f77
failing spec
vaughankg Sep 15, 2014
3bd6caf
fix the :all method
vaughankg Sep 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion motion/adapters/array_model_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def find_by_id(id)

# Returns query result as an array
def all
collection
collection.dup
end

def order(field_name = nil, &block)
Expand Down
8 changes: 8 additions & 0 deletions spec/model_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,3 +300,11 @@ class ProtectedTimestamps
end
end
end

describe "#all" do
it "should return a new collection" do
x = Task.all.object_id
Task.create
Task.all.object_id.should != x
end
end