Add option to change refresh-interval#136
Open
harmenwassenaar wants to merge 2 commits intomasterfrom
Open
Conversation
harmenwassenaar
force-pushed
the
add-option-on-dashboard-to-change-refresh-interval
branch
from
48e856a to
3c18420
Compare
harmenwassenaar
commented
Jul 4, 2024
| var completed_pb_ids = {}; | ||
| refresh(); | ||
| setInterval(refresh, refresh_interval); | ||
| var interval_id = setInterval(refresh, refresh_interval); |
Collaborator
Author
There was a problem hiding this comment.
For some reason calling refresh() before setting the interval causes finished progress-bars not to show up with the latest commit (neither in firefox nor chrome). But leaving it out causes a half second delay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you use a long-running dashboard, and especially if you have a few stack-traces, the bandwidth consumption can get pretty high, so it would be nice to be able to reduce the refresh rate.
Other options to tackle the issue would be to only request updates for progress-bars that haven't completed/stopped, and perhaps using websockets.