support for multiple files + modified argparse options#1
Open
0rovan wants to merge 1 commit intosyedaali:masterfrom
Open
support for multiple files + modified argparse options#10rovan wants to merge 1 commit intosyedaali:masterfrom
0rovan wants to merge 1 commit intosyedaali:masterfrom
Conversation
Owner
There was a problem hiding this comment.
readlines() will read the entire file in memory, you can easily overwhelm the memory of a system by doing this. I was using 'for line in file' which reads one line at a time. Thoughts?
Author
|
In practice apache logs are relatively small - https://httpd.apache.org/docs/2.2/logs.html#rotation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added support for input from multiple log files to your script and I'd be happy if you want to pull from me. However you may not like changes to argument parser based mainly on my personal preferences .