Skip to content

Only switch to evil lisp state if in evil mode #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

russell
Copy link

@russell russell commented Feb 24, 2016

This is to support this in hybrid environments where users may not be
using evil mode at all, or may be using evil mode in some situations.

I really like what your doing with spacemacs. But I'm finding some inconsistencies when running in holy mode, this package assumes that you are in an Evil mode and then forces you into it. But at the same time i want to be friendly to people running in a hybrid environment. So this is my attempt to only switch to evil if your already in an evil mode. There may be a better condition that could go in there. I've only been using spacemacs for 2 days.

This is to support this in hybrid environments where users may not be
using evil mode at all, or may be using evil mode in some situations.
@syl20bnr
Copy link
Owner

syl20bnr commented Apr 4, 2016

Thank you for the PR 👍
With last develop branch of Spacemacs it should not happen anymore so I'm not sure the PR is still needed, can you confirm ?

@russell
Copy link
Author

russell commented Apr 28, 2016

Hey,

Thanks for the reply. It seems to still throw me into lisp state. The steps i took where, opened .py file. evil-state == emacs
browse to parens
M-m k W
evil-state == lisp

i'm running spacemacs develop b21c7177ec882276161e323eb417fbeaf5b4b814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants