-
Couldn't load subscription status.
- Fork 110
oci: support for SCIF, incl. --app #2348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oci: support for SCIF, incl. --app #2348
Conversation
c4299ad to
6323604
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments left.
More generally, I don't think that having inspect --oci dump out SCIF specific output is right.
- I think
inspect --oci --app xxxoutput is fine to show SCIF app xxxx - I think that
inspect --oci --list-appsshowing all SCIF apps would be fine. - I think that a general
inspect --ocishould show OCI config for any OCI-SIF image... but that is outside of the scope here.
It's probably best to pull out the inspect stuff here, and then...
- Implement the general OCI-SIF inspect.
- Add the SCIF specific piece.
2224ee5 to
920c8a9
Compare
920c8a9 to
cd9d098
Compare
|
Tentative implementation of |
|
Just saw this in my Twitter DMs - sorry I missed the earlier discussion. Super cool and nice job @preminger ! |
Description of the Pull Request (PR):
Adds support for SCIF apps in OCI-mode using
--appcommand-line option.NOTE: This feature assumes a Docker-style SCIF container built with the
scifexecutable as CMD or ENTRYPOINT, as per the instructions in the SCIF tutorial (archived here).This fixes or addresses the following GitHub issues:
--appin--ocimode (SCIF in OCI) #1470