Add a failing test about diff code highlighting#124
Merged
javiereguiluz merged 1 commit intosymfony-tools:mainfrom Oct 22, 2021
Merged
Add a failing test about diff code highlighting#124javiereguiluz merged 1 commit intosymfony-tools:mainfrom
javiereguiluz merged 1 commit intosymfony-tools:mainfrom
Conversation
Contributor
|
Fixed at: doctrine/rst-parser#168 |
javiereguiluz
force-pushed
the
failing_code_diff_test
branch
from
f5c759d to
9c45a43
Compare
javiereguiluz
force-pushed
the
failing_code_diff_test
branch
from
9c45a43 to
ac48cde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wouterj reported that a code block here https://symfony.com/doc/current/security.html#form-login didn't show any highlighting.
It's true. The problem occurs when a
diffcode block doesn't start its first line with+or-In this failing test, the first code block works but the second doesn't(to be completely honest, the first one doesn't work either because of some white space issue which I can't see, but it mostly works)<-- this problem was fixed by Ryan. Thanks!