[make:user] add class name for UniqueConstraint
#1722
+18
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seb-jean
force-pushed
the
update-name-index
branch
from
bc7c75f to
cdf7591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we can have multiple user classes and the index name is then duplicated if we don't change it manually. I added this PR to fix this by prefixing with the class name.
For instance:
I have an Admin and User entity that I generated with
make:user. The email field is used for this index.Before:
I will then have
#[ORM\UniqueConstraint(name: 'UNIQ_IDENTIFIER_EMAIL', fields: ['email'])]for User and Admin entitiesAfter:
For the User entity, this will be:
#[ORM\UniqueConstraint(name: 'USER_UNIQ_IDENTIFIER_EMAIL', fields: ['email'])]For the Admin entity, this will be:
#[ORM\UniqueConstraint(name: 'ADMIN_UNIQ_IDENTIFIER_EMAIL', fields: ['email'])]