add alias for null handler - fixes #133 #400
Conversation
gggeek
changed the title
There was a problem hiding this comment.
Could you please add tests?
In YAML I think you can escape the 'null' to fix solve this, but indeed this is an issue with XML configuration.
I wonder if it worth adding a new specific handler while people can also use the noop handle to achieve almost the same thing..
True, but it still probably bites many developers the first time that they try to set it up. They might find it easier to use
I am not sure I get what you mean here... It seems to me that noop handler and null handler behave differently, as the latter is a blackhole sink, while the former is not (truly, making the difference more visible would be welcome). Besides, this is not a new handler, just as easier way to set up an handler which already exists I'll take a look at tests - but I might need some support with those |
This PR was merged into the 3.x branch. Discussion ---------- Support `null` for the `NullHandler` | Q | A | ------------- | --- | Branch? | 3.x | Bug fix? | yes | New feature? | yes | Deprecations? | no | Issues | Fix #400 Fix #133 | License | MIT The XML config format doesn't support `'null'` string as its always converted to `NULL`, and Yaml requires `'null'` to be quoted. In order to simplify the configuration, the `NULL` value is converted to `'null'` string by the configuration. Commits ------- 047ba44 Support null for the NullHandler
|
It took time, but it's now fixed by #548. Thanks for exploring solution. |
3 participants
Fixes #133