Skip to content

Conversation

@devtronic
Copy link

Q A
License MIT

Since there is no more activity in #270 and my other PR (#210) was closed I'm creating this one

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

"MAILER_SENDER_ADDRESS": "joh.doe@localhost.tld",
"MAILER_SENDER_NAME": "John Doe"
}
} No newline at end of file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should end with a newline

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@devtronic
Copy link
Author

Waiting for FriendsOfSymfony/FOSUserBundle#2780

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.
It seams to be a duplicate of #345. We should work together with that PR to decide how to move forward.


See https://symfony.com/doc/master/bundles/FOSUserBundle/index.html

1. Step 3: Create your User class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add this in the recipe

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This very use case specific. i think, the developer should create the user class on his own

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but we could help the user. We could create a class named User that implements the interface.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can do that

See https://symfony.com/doc/master/bundles/FOSUserBundle/index.html

1. Step 3: Create your User class
2. Step 4: Configure your application\'s security.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also do this in the recipe?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I don't see any way to modify the application's security.yaml through the recipe. Do you've any idea to solve that?

2. Step 4: Configure your application\'s security.yml
(config/packages/security.yaml)

3. Step 6: Import FOSUserBundle routing files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be done in in the recipe

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Before I get back to work i'll wait for the merge of my pull request from above

patrickbussmann added a commit to patrickbussmann/recipes-contrib that referenced this pull request May 16, 2018
@tattali
Copy link
Contributor

tattali commented Jul 3, 2018

Hi there is no activity in #270 because like you I wait that the no-driver PR merged.

If you want to see a recipe for FOSUserBundle take a look and show your support by 👍 on :
FriendsOfSymfony/FOSUserBundle#2708 (comment)

@maxhelias maxhelias mentioned this pull request Aug 15, 2018
@fabpot
Copy link
Member

fabpot commented Sep 3, 2018

Closing as a duplicate (#270)

@fabpot fabpot closed this Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants